Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Assert when local variables shadow modifier invocations #17137

Merged
merged 1 commit into from
Oct 20, 2018

Commits on Oct 20, 2018

  1. [BUGFIX beta] Assert when local variables shadow modifier invocations

    Expanding #17132 to cover modifiers.
    
    ```hbs
    {{#let this.foo as |foo|}}
      <div {{foo}} />
             ~~~ shadowed modifier invocation!
    {{/let}}
    ```
    
    Previously, this would have tried to resolve and invoke the modifier `foo`,
    ignoring the presence of the `foo` local variable. This is inconsistent
    with our general lexical lookup rules. This is now an error (assertion).
    
    This paves the way for allowing "contextual modifiers" in the future, where
    the local variable `foo` contains an invocable modifier value.
    chancancode committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    74b8f60 View commit details
    Browse the repository at this point in the history