Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE ember-routing-router-service] Enable by default. #17061

Merged
merged 1 commit into from
Oct 8, 2018
Merged

[FEATURE ember-routing-router-service] Enable by default. #17061

merged 1 commit into from
Oct 8, 2018

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Oct 8, 2018

Enable the final installment of the router service RFC.

@rwjblue
[FEATURE ember-routing-router-service] Enable by default.
e74f5be 
Enable the final installment of the router service RFC.
chadhietala
chadhietala approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@chadhietala chadhietala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this.

@scalvert
Copy link
Contributor

scalvert commented Oct 8, 2018

👍

@rwjblue rwjblue merged commit a434bf8 into master Oct 8, 2018
@rwjblue rwjblue deleted the MOAR_ROUTER_SERVICE branch October 8, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadhietala chadhietala chadhietala approved these changes

@kategengler kategengler kategengler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwjblue @scalvert @chadhietala @kategengler