[BUGFIX] ES6 classes on/removeListener and observes/removeObserver interop #16874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixin has been applied.
krisselden
changed the title
krisselden
changed the title
pzuraq
approved these changes
Aug 9, 2018
| } | ||
| this._listenersFinalized = true; | ||
| listeners.push(eventName, target, method, flags); |
There was a problem hiding this comment.
should this dedupe entries? Specifically last write win, so that an add followed by remove doesn't leak the add?
stefanpenner
approved these changes
Aug 10, 2018
pondthailamd
approved these changes
Aug 10, 2018
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Aug 30, 2018
…er interop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Aug 30, 2018
…er interop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Aug 31, 2018
…er interop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Sep 26, 2018
…er interop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Sep 27, 2018
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Sep 27, 2018
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Sep 27, 2018
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Sep 27, 2018
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Oct 2, 2018
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Oct 11, 2018
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Oct 15, 2018
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
|
This was superseded by #16923. |
rwjblue
pushed a commit
that referenced
this pull request
Oct 29, 2018
…terop v2 This is a rework of #16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later. (cherry picked from commit b3bcc7a)
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Oct 31, 2018
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Oct 31, 2018
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Oct 31, 2018
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Oct 31, 2018
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
|
Thank you @btecu, I had missed that... |
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Dec 14, 2018
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
pzuraq
added a commit
to pzuraq/ember.js
that referenced
this pull request
Jan 23, 2019
…terop v2 This is a rework of emberjs#16874 which flattens and caches the state of event listeners more efficiently. Rather than rebuild the result of a `matchListeners` query each time, including deduping, we flatten the listeners down the hierarchy of metas the first time an event match is requested. This still defers the majority of the work early on (adding listeners is cheap) but also prevents us from having to do the work again later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mixin has been applied.