[BUGFIX] Centralize build versioning info #16813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
rwjblue
approved these changes
Jul 12, 2018
|
rwjblue
reviewed
Jul 12, 2018
| * @param {string} txt | ||
| */ | ||
| function escapeSemVerIdentifier(txt) { | ||
| return txt.replace(NON_SEMVER_IDENTIFIER, '-'); |
There was a problem hiding this comment.
this is fixed now
kategengler
approved these changes
Jul 12, 2018
Make BUILD_TYPE only affect published buildType if on master so we don't accidentally publish from lts/release branches over the current beta or release. Only use a tag as version if it is parseable by semver. The build-for-publishing script uses git info instead of travis env.
krisselden
force-pushed
the
cleanup-build-info
branch
from
4147869
to
45f64c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make BUILD_TYPE only affect published buildType if on master so we don't accidentally publish from lts/release branches over the current beta or release.
Only use a tag as version if it is parseable by semver.
The build-for-publishing script uses git info instead of travis env.
Fixes #16765 (once backported)