use applyMixin directly instead of using it through Mixin
#16732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekzod
commented
Jun 9, 2018
| @@ -31,7 +32,6 @@ import { assert } from '@ember/debug'; | |||
| import { DEBUG } from '@glimmer/env'; | |||
| import { ENV } from 'ember-environment'; | |||
|
|
|||
| const applyMixin = Mixin._apply; | |||
There was a problem hiding this comment.
probably code remains from days when dependencies where imported with global objects https://github.com/emberjs/ember.js/blob/97138247da55eee89be39fd98978c26b86b1aec4/packages/ember-runtime/lib/system/core_object.js
bekzod
commented
Jun 9, 2018
| return (applyMixin as any)(...arguments); | ||
| } | ||
|
|
||
| static applyPartial(obj: any, ...args: any[]) { |
There was a problem hiding this comment.
removed static applyPartial since it is undocumented does not have usage in wild, and applyMixin could be used instead
krisselden
approved these changes
Jun 9, 2018
|
ping tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is cleaner and readable just to export
applyMixinand use it directly instead of accessing thoughMixin