[BUGFIX release] Fix descriptorFor to support fallback #16653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisselden
force-pushed
the
pr16602
branch
2 times, most recently
from
8a3947d
to
26ea077
Compare
Test that a CP descriptor still works with notifyPropertyChange when it is not setup correctly via Ember.defineProperty.
rwjblue
reviewed
May 18, 2018
| currentValue.setup(obj, keyName); | ||
| } | ||
|
|
||
| return currentValue.get(obj, keyName); |
There was a problem hiding this comment.
Don’t we want to call currentValue.set(obj, keyName, value)? Why would we call .get?
Setup a non setup descriptor on access.
rwjblue
approved these changes
May 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure all fallback cases are deprecated.
Fixes #16427 and add test for
notifyPropertyChangenot working for plain obj.