Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(link-to): add id to "inactive loading state" warning #16281

Merged
merged 1 commit into from
Feb 24, 2018

Conversation

lennyburdette
Copy link
Contributor

Without an ID, this triggers an assertion with the message "When calling warn you must provide an options hash as the third parameter. options should include an id property."

Without an ID, this triggers an assertion with the message "When calling warn you must provide an options hash as the third parameter. options should include an id property."
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rwjblue rwjblue merged commit 623336b into emberjs:master Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants