Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX lts] Enable _some_ recovery of errors thrown during render. #16174

Merged
merged 1 commit into from
Jan 25, 2018
Merged

[BUGFIX lts] Enable _some_ recovery of errors thrown during render. #16174

merged 1 commit into from
Jan 25, 2018

Commits on Jan 25, 2018

  1. [BUGFIX lts] Enable _some_ recovery of errors thrown during render. 

    If `env.commit()` is not called after it has started, and another
`env.begin()` starts Glimmer throws an error:

```
Error: a glimmer transaction was begun, but one already exists. You may have a nested transaction
```

This commit works around the issue by ensuring that if a transaction had
been started, it is cleaned up even if an error was thrown during render.
    @rwjblue
    rwjblue committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    11bec3f View commit details
    Browse the repository at this point in the history