Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move expectDeprecation and expectNoDeprecation onto assert #16136

Closed
wants to merge 3 commits into from

Conversation

thoov
Copy link
Member

@thoov thoov commented Jan 17, 2018

Apart of #15988

Moves expectDeprecation, expectNoDeprecation, and ignoreDeprecation onto assert and off of the window global.

This PR does the following:

  • Moves expectDeprecation, expectNoDeprecation, & ignoreDeprecation onto assert
  • Refactors all tests that use these methods to be invoked off of assert.
  • Adds test cases for assert.expectDeprecation & assert.expectNoDeprecation

@thoov thoov changed the title [WIP] Move expectDeprecation and expectNoDeprecation onto assert Move expectDeprecation and expectNoDeprecation onto assert Feb 8, 2018
@locks
Copy link
Contributor

locks commented Apr 22, 2018

@thoov you might need to rebase this ;x

@thoov thoov closed this Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants