New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Move computed and controllers tests to new testing style #16123

Closed

mikerhyssmith wants to merge 1 commit into emberjs:master from mikerhyssmith:ember-runtime-unify-computed-controllers

Contributor

mikerhyssmith commented Jan 14, 2018

Part of #15988

I had a couple of questions on this one:

Im not sure what the right approach is for this situation with nested moduleFors:
https://github.com/emberjs/ember.js/compare/master...mikerhyssmith:ember-runtime-unify-computed-controllers?expand=1#diff-cf61b28086fbaee1f14d6212760e1c9dL85

I also wasn't sure the best way of moving the commonSortTests to the new style ? Does it potentially need its own testCase class ?
https://github.com/emberjs/ember.js/compare/master...mikerhyssmith:ember-runtime-unify-computed-controllers?expand=1#diff-bf8afcf2ee2cba77bd823d03fd48ba7eR719


          Move computed and controllers tests to new style

2eeff14

locks requested a review from rwjblue

January 16, 2018 01:10

Contributor

btecu commented Oct 19, 2018

Needs a rebase.

Member

Turbo87 commented Dec 19, 2018

looks like this was done in #16441 already

Turbo87 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet