Work towards using QUnit 2 APIs. #16061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports both `teardown` and `afterEach` for now...
|
@thoov - This is somewhat related to the general purpose "test cleanup" quest issue, would you mind reviewing? |
thoov
reviewed
Jan 5, 2018
| @@ -108,5 +108,5 @@ function assertDirty(obj, callback, label) { | |||
| let tag = tagFor(obj); | |||
| let tagValue = tag.value(); | |||
| callback(); | |||
| ok(!tag.validate(tagValue), label); | |||
| QUnit.config.current.assert.ok(!tag.validate(tagValue), label); | |||
There was a problem hiding this comment.
Whats your take on this vs passing assert into assertDirty?
There was a problem hiding this comment.
just my own laziness I think
There was a problem hiding this comment.
I think there is just one occurrence of assertDirty so I say we hook it up and then merge this
|
Other than the one comment I had it LGTM. Tagging #15988 so it shows up on the quest issue |
This is 🍌s and I don't like it one bit, but I also don't want to wait 3 times as long for the test suite to finish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates ember-runtime and ember-metal to using QUnit 2 APIs (avoiding global assertions, using beforeEach/afterEach instead of setup/teardown, etc).
It also updates the test harness for
moduleForand the olderember-devsystem to honor bothsetup/teardownandbeforeEach/afterEach.