Inline ember-dev into internal-test-helpers package. #16054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I have the move from expectDeprecation to assert.expectDeprecation as a tracked item here: #15988 |
rwjblue
force-pushed
the
inline-ember-dev
branch
from
200e3f7
to
a4154f5
Compare
The ember-dev project on github was archived (to signify that this is **not** recommended as a go forward pacakge that app / addon authors should use). Copies over all of `emberjs/ember-dev` repo into our own `internal-test-helpers` package. This allows us to iterate our tests to slowly start using `assert.expectDeprecation` / `assert.expectAssertion` / etc and to gradually remove the complexity in these helpers.
The prior code completely ignored any promises being returned, and as such forced a bunch of "run loop sprinkles" throughout the code. This brings back the ability to return promises from `beforeEach` / `setup` and from `teardown`.
krisselden
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ember-dev project on github was archived (to signify that this is not recommended as a go forward pacakge that app / addon authors should use).
Copies over all of
emberjs/ember-devrepo into our owninternal-test-helperspackage. This allows us to iterate our tests to slowly start usingassert.expectDeprecation/assert.expectAssertion/ etc and to gradually remove the complexity in these helpers.