[Cleanup] Convert container tests to new style

[t-sauer]

See #15988

Two things I observed while converting:

• expectAssertion and expectDeprecation are not available on this.assert. Is this intended? Is there a newer replacement for that?
• There are a couple of assert.expect(1) which is not needed as far as I know, correct?

[rwjblue]

expectAssertion and expectDeprecation are not available on this.assert. Is this intended? Is there a newer replacement for that?

Yes, we should migrate to a custom assert.throws implementation (basically something that is aware of production and "does the right thing"). Definitely fodder for a future quest issue...

There are a couple of assert.expect(1) which is not needed as far as I know, correct?

Correct, however when assertions are not in the top down flow of code I do think we should have an assert.expect. Basically require-expect with the except-simple config option.

[rwjblue]

Looks good to me, I only have one general comment around using assert argument instead of this.assert, but I'm happy to tackle that in a follow up...

[rwjblue]

I'd generally prefer to add assert as the callback arg and use it below (instead of this.assert). It is simpler, and "feels" more idiomatic to me.

@chancancode / @thoov / @locks - Thoughts?

[locks]

I've been doing this.assert because of the code linked in the quest issue, but I prefer the argument version too.

[thoov]

I agree with having assert as an argument over off of this. Definitely is more "standard" when looking at docs and existing testing approaches in the wild. I will update the issue to have more clear explanations about things we are looking for and better examples

[t-sauer]

Updated from this.assert to the assert argument.

[rwjblue]

Thank you!