[BUGFIX beta] assert that classNameBinding items are strings
#15924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Dec 7, 2017
| @@ -412,6 +412,18 @@ export function validatePositionalParameters(named: NamedArguments, positional: | |||
| } | |||
|
|
|||
| export function processComponentInitializationAssertions(component: Component, props: any) { | |||
| assert(`classNameBindings must be strings: ${component.toString()}`, (() => { | |||
There was a problem hiding this comment.
Seems fine, but I would have assumed that the explicit .toString() shouldn't have been needed inside template strings. Mind confirming?
There was a problem hiding this comment.
Yep, that's the case. I've updated the other similar tests to remove toString and use template strings too
| for (let i = 0; i < classNameBindings.length; i++) { | ||
| let binding = classNameBindings[i]; | ||
|
|
||
| if (typeof(binding) !== 'string') { |
There was a problem hiding this comment.
I think we generally prefer typeof binding !== 'string'
|
@rwjblue thanks for the feedback, the PR has been updated and is ready for review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15851
(this was part of an Ember open source workshop in Intercom)