Removed console polyfills/shims #15881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Nov 29, 2017
packages/ember-console/lib/index.js
Outdated
| @@ -56,7 +22,7 @@ export default { | |||
| @param {*} arguments | |||
| @public | |||
| */ | |||
| log: consoleMethod('log') || K, | |||
| log: console.log, // eslint-disable-line no-console, no-undef | |||
There was a problem hiding this comment.
I'm slightly torn here, I don't know if we can use console.log unbound from console for all supported platforms. Do you know?
The safe bet here is essentially to do:
log() { return console.log(...arguments); }There was a problem hiding this comment.
Tried var log = console.log; log('foo'); in Safari, Firefox, Chrome and IE 11. Worked everywhere.
I can change it to be safe though.
There was a problem hiding this comment.
Checkout this MS Edge screenshot:
I think this is for console.debug?
There was a problem hiding this comment.
@t-sauer - No rush here, just curious if you had time to review?
There was a problem hiding this comment.
I am on it right now. Seems like .bind(console) is indeed needed in some cases.
t-sauer
force-pushed
the
remove-console-polyfills
branch
from
a85fcb2
to
44339cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is safe to add
consoleof available globals in the ESLint config now that IE 9 support is removed, so I could also change that.