[BUGFIX release] Update backburner.js to 1.2.1. #15677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diff between [v1.1.0 and v1.2.0](BackburnerJS/backburner.js@v1.1.0...v1.2.1) includes the following changes: * Allow `onError` to be late bound (and recalculated for each flush). * Make `now()` late bound (allowing for things like `sinon.useFakeTimers()`).
Previously, this test assumed that the only value on `backburner._platform` that was required was `setTimeout`. As of Backburner 1.2.1 this is no longer true (it also requires `.now()`), and really should not have been assumed to begin with. This change simply ensures that `backburner._platform` continues to have all the same methods on it, but uses the test override of `setTimeout` to run its assertions.
|
Closing this, rolled changes into #15600 which was also working on a Backburner version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff between v1.1.0 and v1.2.0 includes the following changes:
onErrorto be late bound (and recalculated for each flush).now()late bound (allowing for things likesinon.useFakeTimers()).