Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX LTS] ensure “pause on exception” pauses in the right place #15600

Merged
merged 4 commits into from
Sep 21, 2017
Merged

[BUGFIX LTS] ensure “pause on exception” pauses in the right place #15600

merged 4 commits into from
Sep 21, 2017

Commits on Sep 21, 2017

  1. [BUGFIX LTS] ensure “pause on exception” pauses in the right place 

    It is quite common (like in ember-data’s tests) to not have a global onError handler in tests.
But because of the previous state of code, we would still end up paused in the default dispatchError rather then where the actual error was thrown.

This addresses the issue, but ensuring onErrorTarget.onerror returns undefined if no onError has been set
    @stefanpenner @rwjblue
    stefanpenner authored and rwjblue committed Sep 21, 2017
    Configuration menu
    Copy the full SHA
    54040ec View commit details
    Browse the repository at this point in the history

  2. [BUGFIX release] Update backburner.js to 1.2.1. 

    The diff between [v1.1.0 and
v1.2.0](BackburnerJS/backburner.js@v1.1.0...v1.2.1)
includes the following changes:

* Allow `onError` to be late bound (and recalculated for each flush).
* Make `now()` late bound (allowing for things like
  `sinon.useFakeTimers()`).
    @rwjblue
    rwjblue committed Sep 21, 2017
    Configuration menu
    Copy the full SHA
    8ad2db4 View commit details
    Browse the repository at this point in the history

  3. [BUGFIX beta] Cleanup test to ensure backburner._platform is present. 

    Previously, this test assumed that the only value on
`backburner._platform` that was required was `setTimeout`.  As of
Backburner 1.2.1 this is no longer true (it also requires `.now()`), and
really should not have been assumed to begin with.

This change simply ensures that `backburner._platform` continues to have
all the same methods on it, but uses the test override of `setTimeout`
to run its assertions.
    @rwjblue
    rwjblue committed Sep 21, 2017
    Configuration menu
    Copy the full SHA
    6e24523 View commit details
    Browse the repository at this point in the history

  4. [BUGFIX lts] Fix test issues exposed by not swallowing errors. 

    Previously, due to always running within a try/catch these errors were
swallowed in production build test runs.
    @rwjblue
    rwjblue committed Sep 21, 2017
    Configuration menu
    Copy the full SHA
    db55502 View commit details
    Browse the repository at this point in the history