[BUGFIX beta] Include missing sourcemaps in vendorTree #15577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Aug 10, 2017
|
@rwjblue it sounds like this was included in v2.15, but I'm pretty sure v2.15 caused ember-cli/ember-cli-terser#29 (comment) for me 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15464
This adds the missing sourcemap files to
vendorTree, so the references in.jsfiles (//# sourceMappingURL=ember.debug.map) are not pointing to non-existing files anymore.There were no existing tests for the addon-output, so not sure if I should add some? (maybe separate PR?). Tested this in a real app, seems to work fine so far:
Also not sure if this should rather be tagged for
releaserather thanbeta?cc @rwjblue