[BUGFIX beta] Refactor ember-debug to support better prod stripping. #15224
Conversation
Prior to this change, things like `Ember.assert` and `Ember.runInDebug` were still firing in production builds.
|
Much easier to review this via: https://github.com/emberjs/ember.js/pull/15224/files?w=1 |
|
Here is a zip file of the assets (debug + prod + min) if folks want to review those too: |
| */ | ||
| deprecate = function deprecate(message, test, options) { | ||
| if (!options || (!options.id && !options.until)) { | ||
| deprecate( |
There was a problem hiding this comment.
Doesn't this cause a stack overflow?
There was a problem hiding this comment.
I had a similar thought, but no because we are passing options and options.id and options.until. If we remove the guarding if (and move those conditions to the deprecate's predicate) it would be a stack overflow.
|
@rwjblue One of our internal addons just started failing in beta and canary because |
|
Confirm. Thank you for spotting and reporting so quickly. |
|
@rwjblue I've hit the same issue in |
Prior to this change, things like
Ember.assertandEmber.runInDebugwere still firing in production builds. Lots of debug specific code was also left in the minified builds.