Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean router service #15068

Merged
merged 2 commits into from
Mar 26, 2017
Merged

Clean router service #15068

merged 2 commits into from
Mar 26, 2017

Conversation

Exelord
Copy link
Contributor

@Exelord Exelord commented Mar 25, 2017

This PR will clean unused imports in RouterService and improve readability of computed properties.

locks
locks requested changes Mar 25, 2017
View reviewed changes
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Exelord, thanks for contributing! Could you leave the computed properties as they were and only remove the unused imports?

@Exelord
Copy link
Contributor Author

Exelord commented Mar 25, 2017

OK,
but what about router: null. I think this should be added to keep the interface of service clear and explicit.

@rwjblue
Copy link
Member

rwjblue commented Mar 25, 2017

router: null seems good to me

Also, if you have the time, could you update our linting config to error for these sorts of unused imports (in a follow up PR)?

@locks locks merged commit 6edfda7 into emberjs:master Mar 26, 2017
@homu homu mentioned this pull request Mar 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Exelord @rwjblue @locks