Allow mounting routeless engines with a bound engine name #15015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM @dgeb / @chancancode / @trentmwillis - Any objections? |
trentmwillis
suggested changes
Mar 14, 2017
| return this._lastDef; | ||
| return this._lastDef; | ||
| } else { | ||
| return null; |
There was a problem hiding this comment.
IMO this should log if the argument isn't a string/undefined/null.
|
@trentmwillis Thanks for the review, I've added an assertion to check that the provided engine name is valid and also added a test to go along with it. cc/ @rwjblue |
Assert when an invalid engine name is passed to {{mount}}
Fix {{mount}} tests
mike183
force-pushed
the
bound-mount-syntax
branch
from
1aef789
to
28c94ec
Compare
rwjblue
approved these changes
Mar 18, 2017
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon the work in #14967, introducing the ability to pass bound properties to the
{{mount}}syntax, enabling the dynamic mounting of "routeless" engines.This also resolves ember-engines/ember-engines#117
cc/ @rwjblue