-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small cleanup of eachDestroyable #15010
Conversation
@bekzod looks good! |
will be it too much if I change |
nope, sounds good. |
@homu r+ |
📌 Commit dc2abee has been approved by |
small cleanup of eachDestroyable Since utility function `eachDestroyable` iterates destroyable items, and most of the time probably destroyable items iterated to be destroyed, I think it is better to destroy them immediately. Free to reject if I am misunderstanding something :P
💥 Test timed out |
@homu retry |
small cleanup of eachDestroyable Since utility function `eachDestroyable` iterates destroyable items, and most of the time probably destroyable items iterated to be destroyed, I think it is better to destroy them immediately. Free to reject if I am misunderstanding something :P
💥 Test timed out |
☔ The latest upstream changes (presumably #15014) made this pull request unmergeable. Please resolve the merge conflicts. |
needs rebase I believe |
dc2abee
to
462bab0
Compare
rebased :) |
Since utility function
eachDestroyable
iterates destroyable items, and most of the time probably destroyable items iterated to be destroyed, I think it is better to destroy them immediately.Free to reject if I am misunderstanding something :P