-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default the template helper test blueprint to integration style #14970
Default the template helper test blueprint to integration style #14970
Conversation
I'm in favor of making |
c98e402
to
4daf0ca
Compare
Does this impact the testing guides? |
@locks looks like the unit testing section in the testing guide uses models as the de facto unit test. I'm not sure if we'd see problems with this change elsewhere. Regardless I'm having a little bit of difficulty figuring out these last few failures. Hopefully will be able to spend some time on them tomorrow. |
4daf0ca
to
9ace9fe
Compare
I believe this should pass now, but not sure if it is retriggering a build. 🤔 |
Seems likely that the delay/issue is related to AWS issues (see https://www.traviscistatus.com/ for details). |
9ace9fe
to
73411d0
Compare
Rebased against master and that triggered the build. 🎉 |
LGTM, @stefanpenner r? |
Potentially bike-shedding, but I find integration style template-helper tests to be more useful in day-to-day use. This commit only changes default behavior to integration.
Would love to have a discussion about the relative pros and cons of the proposed change.
Cheers!