Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Glimmer #14954

Merged
merged 1 commit into from
Mar 3, 2017
Merged

Update Glimmer #14954

merged 1 commit into from
Mar 3, 2017

Conversation

chadhietala
Copy link
Contributor

@chadhietala chadhietala commented Feb 24, 2017 •
edited
Loading

This commit brings glimmer master and ember master in line.

@chadhietala chadhietala changed the title Add Glimmer iterator interface Update Glimmer Mar 2, 2017
@chadhietala chadhietala force-pushed the glimmer-iterator branch 2 times, most recently from 586d038 to fc875da Compare March 2, 2017 22:56
chancancode
chancancode reviewed Mar 2, 2017
View reviewed changes
packages/ember-glimmer/lib/environment.js Outdated

// helpers are not allowed to include a dot in their invocation
if (nameParts.length > 1) {
if (name.indexOf('.') > 1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️ I took care of this in the pre-compiler already

chancancode
chancancode reviewed Mar 2, 2017
View reviewed changes
packages/ember-glimmer/lib/environment.js Outdated
// modifiers are not allowed to include a dot in their invocation
if (nameParts.length > 1) {
if (name.indexOf('.') > -1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️ I took care of this in the pre-compiler already

@rwjblue
Copy link
Member

rwjblue commented Mar 2, 2017 •
edited
Loading

Need some more cases for the AST transform:

{{foo.bar bar="something"}}
{{foo.bar derp}}
{{#foo.bar}}stuff here{{/foo.bar}}
{{this.modal show=maybeShow}}

Specifically, rendering previously saved off closure components that are not derived from block params is totally valid and should be supported.

@chadhietala chadhietala merged commit b0555ba into emberjs:master Mar 3, 2017
@rwjblue
Copy link
Member

rwjblue commented Mar 3, 2017

👏

@toranb toranb mentioned this pull request Mar 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancancode chancancode chancancode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chadhietala @rwjblue @chancancode