Resolve no-unused-vars, no-undef eslint warnings

.eslintrc.js

@@ -37,9 +37,9 @@ var options = {
   rules: {
     'ember-internal/require-yuidoc-access': 'error',
     'ember-internal/no-const-outside-module-scope': 'error',
+    'no-unused-vars': ["error", { "args": "none" }],
 
     // temporarily disabled
-    'no-unused-vars': 'off',
     'comma-dangle': 'off',
   },
 };

packages/ember-application/lib/system/application.js

@@ -332,7 +332,7 @@ const Application = Engine.extend({
   */
   _globalsMode: true,
 
-  init(options) {
+  init() {
     this._super(...arguments);
 
     if (!this.$) {

packages/ember-application/lib/system/resolver.js

@@ -270,7 +270,7 @@ export default EmberObject.extend({
     return description;
   },
 
-  makeToString(factory, fullName) {
+  makeToString(factory) {
     return factory.toString();
   },
 

packages/ember-console/lib/index.js

@@ -1,3 +1,4 @@
+/* global console */
 import { context } from 'ember-environment';
 
 function K() {}

packages/ember-glimmer/lib/components/link-to.js

@@ -533,7 +533,7 @@ const LinkComponent = EmberComponent.extend({
     @private
   */
   disabled: computed({
-    get(key, value) {
+    get() {
       return false;
     },
     set(key, value) {

packages/ember-glimmer/tests/integration/helpers/render-test.js

@@ -1,4 +1,4 @@
-import { observer, set, computed } from 'ember-metal';
+import { set } from 'ember-metal';
 import { Controller } from 'ember-runtime';
 import { RenderingTest, moduleFor } from '../../utils/test-case';
 import { EMBER_GLIMMER_ALLOW_BACKTRACKING_RERENDER } from 'ember/features';
@@ -235,12 +235,8 @@ moduleFor('Helpers test: {{render}}', class extends RenderingTest {
     this.owner.register('controller:post', Controller.extend());
     this.registerTemplate('post', '<p>{{model.title}}</p>');
 
-    let postDidChange = 0;
     expectDeprecation(() => {
       this.render(`<h1>HI</h1>{{render 'post' post}}`, {
-        postDidChange: observer('post', function() {
-          postDidChange++;
-        }),
         post: {
           title: `It's Simple Made Easy`
         }

packages/ember-metal/lib/mixin.js

@@ -37,7 +37,6 @@ import {
   removeListener
 } from './events';
 
-const a_slice = Array.prototype.slice;
 const a_concat = Array.prototype.concat;
 const { isArray } = Array;
 

packages/ember-metal/tests/accessors/get_test.js

@@ -47,11 +47,6 @@ testBoth('should call unknownProperty on watched values if the value is undefine
     }
   };
 
-  let count = 0;
-  addObserver(obj, 'foo', function() {
-    count++;
-  });
-
   equal(get(obj, 'foo'), 'FOO', 'should return value from unknown');
 });
 

packages/ember/tests/helpers/link_to_test/link_to_transitioning_classes_test.js

@@ -25,8 +25,6 @@ function assertHasClass(className) {
   }
 }
 
-let updateCount, replaceCount;
-
 function sharedSetup() {
   App = Application.create({
     name: 'App',
@@ -35,16 +33,13 @@ function sharedSetup() {
 
   App.deferReadiness();
 
-  updateCount = replaceCount = 0;
   App.Router.reopen({
     location: NoneLocation.create({
       setURL(path) {
-        updateCount++;
         set(this, 'path', path);
       },
 
       replaceURL(path) {
-        replaceCount++;
         set(this, 'path', path);
       }
     })

packages/ember/tests/helpers/link_to_test/link_to_with_query_params_test.js

@@ -27,8 +27,6 @@ function checkActive(selector, active) {
   equal(classList.indexOf('active') > -1, active, selector + ' active should be ' + active.toString());
 }
 
-let updateCount, replaceCount;
-
 function sharedSetup() {
   App = Application.create({
     name: 'App',
@@ -37,16 +35,13 @@ function sharedSetup() {
 
   App.deferReadiness();
 
-  updateCount = replaceCount = 0;
   App.Router.reopen({
     location: NoneLocation.create({
       setURL(path) {
-        updateCount++;
         set(this, 'path', path);
       },
 
       replaceURL(path) {
-        replaceCount++;
         set(this, 'path', path);
       }
     })

packages/ember/tests/routing/router_service_test/basic_test.js

@@ -1,8 +1,5 @@
-import { inject } from 'ember-runtime';
-import { Component } from 'ember-glimmer';
 import { Route, NoneLocation } from 'ember-routing';
 import {
-  get,
   set
 } from 'ember-metal';
 import {

packages/ember/tests/routing/router_service_test/currenturl_lifecycle_test.js

@@ -3,7 +3,7 @@ import {
   readOnly
 } from 'ember-runtime';
 import { Component } from 'ember-glimmer';
-import { Route, NoneLocation } from 'ember-routing';
+import { Route } from 'ember-routing';
 import { get } from 'ember-metal';
 import {
   RouterTestCase,

packages/ember/tests/routing/router_service_test/transitionTo_test.js

@@ -3,8 +3,7 @@ import { Component } from 'ember-glimmer';
 import { Route, NoneLocation } from 'ember-routing';
 import {
   run,
-  get,
-  set
+  get
 } from 'ember-metal';
 import {
   RouterTestCase,

packages/external-helpers/lib/external-helpers-prod.js

@@ -48,4 +48,4 @@ export const possibleConstructorReturn = (function (self, call) {
   return call && (typeof call === 'object' || typeof call === 'function') ? call : self;
 });
 
-export const slice = Array.prototype.slice;
+export const slice = Array.prototype.slice;

packages/loader/lib/index.js

@@ -1,4 +1,7 @@
+/* global process */
 var enifed, requireModule, Ember;
+
+// eslint-disable-next-line no-unused-vars
 var mainContext = this; // Used in ember-environment/lib/global.js
 
 (function() {