[BUGFIX beta] Add back mainContext to loader #14859 #14860
Conversation
| @@ -14,5 +14,4 @@ function checkElementIdShadowing(value) { | |||
| export default checkGlobal(checkElementIdShadowing(typeof global === 'object' && global)) || | |||
| checkGlobal(typeof self === 'object' && self) || | |||
| checkGlobal(typeof window === 'object' && window) || | |||
| mainContext || // set before strict mode in Ember loader/wrapper | |||
There was a problem hiding this comment.
Can you bring this back, and add it back to the correct location in loader.js? The ESLint cleanup PR should not have removed it (and I missed that it did when I reviewed).
There was a problem hiding this comment.
Sorry about that. Can we add a comment to it this time describing what the unused variable does?
There was a problem hiding this comment.
And also add a // eslint-disable-next-line no-unused-vars line before the mainContext definition in packages/loader/lib/index.js (even though no-unused-vars is globally off for now)
Still, i'm a bit puzzled by the global.js code... If mainContext is defined nowhere, the code will still fail. And if it is, the next line new Function('return this')() will never run.
Would it make sense to replace mainContext with (typeof mainContext === 'object' && mainContext) ?
zoltan-nz
changed the title
|
Thank you! |
Fixing #14859
After the ESLint warning cleanup the
mainContextis undefined and brake the ember-template-compiler.js compilation in grunt environment.This PR removes the rest of the
mainContextreference from theglobal.js.Previous conversation about this issue:
e24e403#diff-5b2ea89606fd2097e9e17d66ae54ed51L2
Opened issue in grunt-ember-templates repo: dgeb/grunt-ember-templates#94
cc @Turbo87 @andyhot