Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance] only logLibraryVersions in debug mode #14829

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

GavinJoyce
Copy link
Member

@GavinJoyce GavinJoyce commented Jan 12, 2017

@rwjblue
Copy link
Member

rwjblue commented Jan 12, 2017

We should also remove the invocation here by wrapping in runInDebug so the whole function gets DCE by uglify.

@GavinJoyce GavinJoyce changed the title [wip][performance] only logLibraryVersions in debug mode [performance] only logLibraryVersions in debug mode Jan 12, 2017
@@ -339,7 +340,7 @@ const Application = Engine.extend({
}

registerLibraries();
logLibraryVersions();
runInDebug(() => logLibraryVersions());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this with the no-opping body?

@GavinJoyce
Copy link
Member Author

GavinJoyce commented Jan 12, 2017 via email

@rwjblue
Copy link
Member

rwjblue commented Jan 12, 2017

LGTM, will land once CI is finished.

@GavinJoyce
Copy link
Member Author

GavinJoyce commented Jan 13, 2017

🍏 🚢

@rwjblue rwjblue merged commit 10bae79 into emberjs:master Jan 13, 2017
@GavinJoyce GavinJoyce deleted the gj/skip-log-library-versions branch January 14, 2017 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants