Fixed string capitalize for accented characters #14764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Feb 26, 2017
| @@ -60,7 +60,7 @@ const UNDERSCORE_CACHE = new Cache(1000, function(str) { | |||
| replace(STRING_UNDERSCORE_REGEXP_2, '_').toLowerCase(); | |||
| }); | |||
|
|
|||
| const STRING_CAPITALIZE_REGEXP = (/(^|\/)([a-z])/g); | |||
| const STRING_CAPITALIZE_REGEXP = (/(^|\/)([a-zA-Z\u00C0-\u024F])/g); | |||
There was a problem hiding this comment.
I'm not sure I understand why A-Z was added here, can you explain?
There was a problem hiding this comment.
you're right :) I'll remove A-Z from the regex
IgorKvasn
force-pushed
the
capitalize-fix
branch
from
4614dfa to
5c03a45
Compare
locks
approved these changes
Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String capitalize function did not work properly, when first character is accented (e.g. ščťžý)