Code cleanup based on ESLint warnings #14603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Nov 11, 2016
| @@ -2224,16 +2218,10 @@ moduleFor('Components test: curly components', class extends RenderingTest { | |||
| } | |||
|
|
|||
| ['@test specifying classNames results in correct class'](assert) { | |||
| let clickyThing; | |||
|
|
|||
| this.registerComponent('some-clicky-thing', { | |||
| ComponentClass: Component.extend({ | |||
| tagName: 'button', | |||
| classNames: ['foo', 'bar'], | |||
There was a problem hiding this comment.
Need to remove this trailing comma
| @@ -2261,15 +2249,10 @@ moduleFor('Components test: curly components', class extends RenderingTest { | |||
| } | |||
|
|
|||
| ['@test specifying custom concatenatedProperties avoids clobbering'](assert) { | |||
| let clickyThing; | |||
| this.registerComponent('some-clicky-thing', { | |||
| ComponentClass: Component.extend({ | |||
| concatenatedProperties: ['blahzz'], | |||
| blahzz: ['blark', 'pory'], | |||
|
@rwjblue done |
|
also fixed the failing JSHint test now... Travis will hopefully agree :) |
|
🍏 |
rwjblue
approved these changes
Nov 11, 2016
|
Still need to squash commmits though |
|
@rwjblue not a fan of squashing in general, but: done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contents in this PR were mostly extracted from #13549
/cc @rwjblue @stefanpenner