-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate renderToElement #14482
Deprecate renderToElement #14482
Conversation
false, | ||
{ | ||
id: 'ember-views.render-to-element', | ||
until: '3.0.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if 3.0.0 is the intended version to drop this, can someone confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this would be until: '2.12.0'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update this then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
|
@Gaurav0 - That really isn't a compelling motivation. Both I totally agree that we should have a public API for this though, maybe you can try your hand at writing the RFC if this is something you need? |
9f6b788
to
67d116e
Compare
Thank you @josemarluedke! |
This implements #14158.
Deprecation guide: emberjs/website#2702.