[Bugfix Beta] Freeze attrs in debug

[chadhietala]

@rwjblue @krisselden I believe there were talks about freezing these as well. I think we want to make attrs pay as you go as well.

[chadhietala]

I actually don't know if we can do this. If you use attrs in the backing class for something like dependent keys on a CP we're going to install meta and thats going to result in

Cannot define property:__ember_meta__, object is not extensible

Specifically I ran into this with Link-to's use of attrs .

[rwjblue]

Yep, that is exactly what #14264 is about.

[rwjblue]

Discussed in Slack, I think changing these lines:

• https://github.com/emberjs/ember.js/blob/master/packages/ember-glimmer/lib/utils/references.js#L145
• https://github.com/emberjs/ember.js/blob/master/packages/ember-glimmer/lib/utils/references.js#L195

To use this as the guard:

if (isFeatureEnabled('mandatory-setter') && !Object.isFrozen(parentValue)) {
}

Should fix?

[krisselden]

It should fix it, to be honest it is annoying we haven't done this for frozen objects already

[rwjblue]

@krisselden - Agreed. I think we also need to do something in the CP system (since {{link-to}} is using attrs.foo as a dependent key).

[krisselden]

That still goes through Ember.watch

[chadhietala]

So guarding here causes a bunch of other things to break, about 1000 tests.

[homu]

☔ The latest upstream changes (presumably #14267) made this pull request unmergeable. Please resolve the merge conflicts.

[krisselden]

@chadhietala that is because there are assumptions about state that it breaks that would need to be updated.

addObserver is addListener + watch. cps use watch directly. there maybe some other cases with isWatching.

Also maybe assumptions about corresponding state in mandatory setter.

I didn't say it would be simple, I just think it is worth it.

You should be able to render a frozen object in a template.

[mmun]

Watching frozen objects works now.