Ensure Controller#transitionToRoute and Route#intermediateTransitionTo work in Engines #14176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // only alter the routeName if it's actually referencing a route. | ||
| if (owner.routable && typeof routeName === 'string') { | ||
| if (resemblesURL(routeName)) { | ||
| throw new EmberError('Route#transitionTo cannot be used for URLs. Please use the route name instead.'); |
There was a problem hiding this comment.
Hard-coded source Route#transitionTo.
|
☔ The latest upstream changes (presumably #14199) made this pull request unmergeable. Please resolve the merge conflicts. |
trentmwillis
force-pushed
the
prefix-route-name
branch
from
9b1170c
to
e97d855
Compare
…o work in Engines Also adds basic tests to verify programmatic transition behavior in Engines.
trentmwillis
force-pushed
the
prefix-route-name
branch
from
e97d855
to
63df7db
Compare
|
Oops, forgot to ask about commit prefix. I think this should target release, c/d? |
I believe so since it's a gap in functionality of the current release. |
|
OK, I've cherry-picked into beta, but I think we need to PR directly against release. Lots of conflicts (due to imports changing from absolute to relative and removing the engines feature flag), and I'd like to get a CI run. Would you mind doing that? |
|
@rwjblue sure, I'll try to get to it sometime this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing ember-engines/ember-engines#159 and ember-engines/ember-engines#186.
Planning to add tests (though there don't seem to be any tests for related features).