[BUGFIX beta] Fix basic component and helper resolution in engines. #14135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces. An engine instance needs to share the following with its parent: * `service:-glimmer-environment` (only for glimmer) * `renderer:-dom` or `renderer:-inert`, depending on whether the environment is interactive
Ensure that Cache lookups are performed using the correct owner. Ensure that engines are destroyed _before_ top-level views so that top-level views are not re-instantiated during engine teardown.
|
Looks like |
|
@asakusuma it seems to be failing only sometimes for some merges :$ |
|
Yes, we have an intermittent issue with FF_Current. |
|
I updated the owner specific stuff to ensure that we do not use the environments owner (which in the case of engines would be the consuming apps not the engines). Still need to add a couple tests around this (where the engine and the app both have a given component/helper but the "right" one is used in each context). |
rwjblue
force-pushed
the
glimmer-owner
branch
3 times, most recently
from
aafd6fe
to
02814c2
Compare
Ensure that the owner being used is not the environments default `Owner`, but it is the owner that the template is being looked up by. For late bound templates this means the components owner, and for normal templates (looked up from registry) it is passed to the factories `.create` method by the container itself.
This was referenced Aug 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase and update of #14112 (to use
symbolTablethroughout) which is a rebase of #14055.Contains the following fixes:
views are not re-instantiated during engine teardown.