[BUGFIX Beta] Bump router.js so that getHandlers is invoked lazily #14044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you prefix the commit with |
trentmwillis
force-pushed
the
router-bump
branch
from
d0d66fa
to
bbd8895
Compare
|
Sure thing, was unsure what prefix to use. |
chadhietala
changed the title
|
@rwjblue looks like this should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up recent changes from router.js. In particular, it makes
getHandlerlazy so that the work is not done upfront if it can be deferred until later (as is needed for lazy Engines). See the PR for the changes here.It also picks up the shaping fixes that @chadhietala made.
cc/ @rwjblue