Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[glimmer2] enable tests fixed by #13615 #13807

Closed
wants to merge 1 commit into from
Closed

[glimmer2] enable tests fixed by #13615 #13807

wants to merge 1 commit into from

Conversation

fivetanley
Copy link
Member

refs #13644

@chadhietala
Copy link
Contributor

These are going to fail until the two-flush branch is merged I believe.

@fivetanley
Copy link
Member Author

fivetanley commented Jul 11, 2016 •
edited
Loading

@chadhietala They seem to pass individually but not when run as a suite. Can you help me understand what the two-flush branch does and why it might fix these issues?

@fivetanley fivetanley mentioned this pull request Jul 16, 2016
Merged
@chancancode
Copy link
Member

@chadhietala I thought they were related, but I debugged this with @fivetanley and I think we just made a mistake (forgetting to clear the DOM when destroying the RenderResult). I am pretty confused how it went unnoticed for so long. We much have some other paths that "incidentally" clears the DOM most of the time so the other tests are not affected by it?

chancancode added a commit that referenced this pull request Jul 17, 2016
@chancancode
Merge pull request #13832 from emberjs/glimmer-test-updates
62d0a35 
#13807 rebased
@chancancode
Copy link
Member

Merged in #13832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fivetanley @chadhietala @chancancode