[BUGFIX release] Fix NoneLocation#getURL #13781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior fixes to NoneLocation and HistoryLocation's getURL broke the case where the rootURL or baseURL matched the start of the main URL. Resolve that case by checking for a subsequent forward slash or end of string.
wagenet
force-pushed
the
fix-none-root-url
branch
from
8d88f11
to
fe473a2
Compare
|
@rwjblue should be good to go! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior fixes to NoneLocation#getURL broke the case where the rootURL
matched the start of the main URL. Resolve that case by checking for
a subsequent forward slash or end of string.