[GLIMMER2] Fix ember-glimmer iterators when handling dupes in ({{#each}}) #13763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to fix array iteration via
{{#each}}
in Glimmer2 when the iteratee contains duplicate items. The following tests fromember-glimmer/tests/integration/syntax/each-test.js
are now passing for Glimmer2:Key changes:
ArrayIterator
andEmberArrayIterator
now keep track of the keys they've seen, and when a duplicate key is seen it creates a composite key using a GUID of the array as a separator.