[Glimmer2] sendAction #13745
Merged
[Glimmer2] sendAction #13745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,7 +132,7 @@ class Renderer { | |||
| let self = new RootReference(view); | |||
| let dynamicScope = new DynamicScope({ | |||
| view, | |||
| controller: view.outletState.render.controller, | |||
| controller: view.outletState.outlets.main.render.controller, | |||
There was a problem hiding this comment.
This seems correct based on this? https://github.com/emberjs/ember.js/blob/master/packages/ember-htmlbars/lib/keywords/outlet.js#L95
chadhietala
force-pushed
the
pr/13532
branch
4 times, most recently
from
ae70186
to
f71a929
Compare
|
Awesome work @Joelkang and @chadhietala! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #13532 and sets up the action "scoping" setting similar to how HTMLBars does it. There are couple tasks that will quickly follow once this has landed:
Part of #13644