Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLIMMER2] Click action links instead of touching action manager internals #13726

Merged
merged 1 commit into from
Jun 21, 2016

Conversation

zackthehuman
Copy link
Contributor

@zackthehuman zackthehuman commented Jun 21, 2016

This should fix the following tests listed in #13644:

  • Events are triggered on the controller if a matching action name is implemented
  • Events are triggered on the current state when defined in actions object
  • Events defined in actions object are triggered on the current state when routes are nested
  • Actions are not triggered on the controller if a matching action name is implemented as a method
  • actions can be triggered with multiple arguments

The ActionManager internals differ between HTMLBars and Glimmer2, and the tests were written in a way that relied on the implementation details. This change simplifies things by doing what a user would do: click on the thing.

@chadhietala
Copy link
Contributor

LGTM and actually makes the tests less about the "how".

@rwjblue rwjblue merged commit 76b054c into emberjs:master Jun 21, 2016
@rwjblue
Copy link
Member

rwjblue commented Jun 21, 2016

Thanks @zackthehuman!

@zackthehuman zackthehuman deleted the action-issues branch June 21, 2016 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants