[glimmer2] fix #each with key option test #13721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ember, you can remove duplicates in an array by providing the
key
option to the
{{#each}}
helper.For example, if given the following
model
property:And the following template:
It would render the following:
Even though we have two objects with "Robert Jackson" as the name, they
share the same "id", so Ember will only render the first object it
encounters with that "id" while iterating. That's why "Robert Jackson"
shows up but not "Robert Jackson with diff name but same ID".
This test was adding in a new object (in our case
{text: ' '}
), but anobject with
{text: ' '}
already existed in the setup line. Because itwas cached by the same
'text'
value, it did not show up in thesubsequent rerender.
We change it to a different text value so we can assert it was added
correctly in the list.
refs #13644