-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLIMMER] Dashed property names #13649
Conversation
f28519a
to
24f6f78
Compare
@@ -139,18 +139,6 @@ QUnit.test('Late-registered components can be rendered with ONLY the template re | |||
ok(!helpers['borf-snorlax'], 'Component wasn\'t saved to global helpers hash'); | |||
}); | |||
|
|||
test('Component-like invocations are treated as bound paths if neither template nor component are registered on the container', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated test.
24f6f78
to
edd799b
Compare
This seems good to me... |
☔ The latest upstream changes (presumably #13658) made this pull request unmergeable. Please resolve the merge conflicts. |
edd799b
to
ad350ca
Compare
The syntax refinement in ember is getting pretty confusing, what about something like this?
|
@chancancode I tried this locally and all of the late bound layout stuff is going to fail. |
6a0e26d
to
ef4c14b
Compare
@@ -133,37 +170,37 @@ export default class Environment extends GlimmerEnvironment { | |||
templates | |||
} = statement; | |||
|
|||
if (key !== 'partial' && isSimple && (isInline || isBlock)) { | |||
assert(`You attempted to overwrite the built-in syntax "${key}" which is not allowed. Please rename the helper.`, !(builtInHelpers[key] && this.owner.hasRegistration(`helper:${key}`))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/syntax/helper
LGTM when build is green 👍 |
ef4c14b
to
1589903
Compare
Should be good to go now. |
Sort of sad that this is even a feature. @krisselden @wycats or @chancancode do you have any suggestions on this, I didn't want to go weaving
isBlock
all over the place.Part of #13644