-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] fixes bugs around baseURL and rootURL in HistoryLocation and introduces rootURL to NoneLocation #13520
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
packages/ember-routing/tests/location/none_location_test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
import { set } from 'ember-metal/property_set'; | ||
import run from 'ember-metal/run_loop'; | ||
import NoneLocation from 'ember-routing/location/none_location'; | ||
|
||
var NoneTestLocation, location; | ||
|
||
function createLocation(options) { | ||
if (!options) { options = {}; } | ||
location = NoneTestLocation.create(options); | ||
} | ||
|
||
QUnit.module('Ember.NoneLocation', { | ||
setup() { | ||
NoneTestLocation = NoneLocation.extend({}); | ||
}, | ||
|
||
teardown() { | ||
run(function() { | ||
if (location) { location.destroy(); } | ||
}); | ||
} | ||
}); | ||
|
||
QUnit.test('NoneLocation.formatURL() returns the current url always appending rootURL', function() { | ||
expect(1); | ||
|
||
NoneTestLocation.reopen({ | ||
init() { | ||
this._super(...arguments); | ||
set(this, 'rootURL', '/en/'); | ||
} | ||
}); | ||
|
||
createLocation(); | ||
|
||
equal(location.formatURL('/foo/bar'), '/en/foo/bar'); | ||
}); | ||
|
||
QUnit.test('NoneLocation.getURL() returns the current path minus rootURL', function() { | ||
expect(1); | ||
|
||
NoneTestLocation.reopen({ | ||
init() { | ||
this._super(...arguments); | ||
set(this, 'rootURL', '/foo/'); | ||
set(this, 'path', '/foo/bar'); | ||
} | ||
}); | ||
|
||
createLocation(); | ||
|
||
equal(location.getURL(), '/bar'); | ||
}); | ||
|
||
QUnit.test('NonoLocation.getURL() will remove the rootURL only from the beginning of a url', function() { | ||
expect(1); | ||
|
||
NoneTestLocation.reopen({ | ||
init() { | ||
this._super(...arguments); | ||
set(this, 'rootURL', '/bar/'); | ||
set(this, 'path', '/foo/bar/baz'); | ||
} | ||
}); | ||
|
||
createLocation(); | ||
|
||
equal(location.getURL(), '/foo/bar/baz'); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we store the normalized
rootURL
, instead of removing the trailing slash on everygetURL
/formatURL
? Perhaps via adding something like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The caveat this introduces is you wouldn't be able to change the rootURL after the router setup. Unsure if that's an actual use case or not though, I would say it's not but I don't know all the crazy ways people use rootURL :) History location is also doing this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense. We could make it a CP with a setter maybe, but I'm not sure it's worth the effort.