Move ENV, environment, context stuff to 'ember-environment' #13319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisselden
force-pushed
the
cleanup-env
branch
5 times, most recently
from
bb1d5c2
to
4fe2be7
Compare
| @@ -34,7 +34,7 @@ | |||
| "ember-cli-sauce": "^1.4.2", | |||
| "ember-cli-yuidoc": "0.8.3", | |||
| "ember-publisher": "0.0.7", | |||
| "emberjs-build": "0.6.4", | |||
| "emberjs-build": "emberjs/emberjs-build#9c7b35a", | |||
There was a problem hiding this comment.
Need to update to 0.7.0 now that it is published
There was a problem hiding this comment.
I updated, it is running tests.
|
@krisselden - This LGTM, and is ready for merge. NPM is being a jerk, and having all sorts of errors downloading [email protected]. |
|
@rwjblue is there an issue with publishing? is it say to merge with that dependency if it isn't downloading? |
|
I can |
|
@krisselden travis might just be hitting a bad replica/mirror, install locally works fine. |
|
Thank you very much, @krisselden! This is some really great work! |
This was referenced Apr 16, 2016
Merged
This was referenced Apr 16, 2016
|
Awesome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ENV stuff, environment, and context to 'ember-environment'.
This is a first step of many to cleanup dependencies and dependency on the
Emberglobal.