-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ENV, environment, context stuff to 'ember-environment' #13319
Conversation
bb1d5c2
to
4fe2be7
Compare
@@ -34,7 +34,7 @@ | |||
"ember-cli-sauce": "^1.4.2", | |||
"ember-cli-yuidoc": "0.8.3", | |||
"ember-publisher": "0.0.7", | |||
"emberjs-build": "0.6.4", | |||
"emberjs-build": "emberjs/emberjs-build#9c7b35a", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update to 0.7.0 now that it is published
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated, it is running tests.
@krisselden - This LGTM, and is ready for merge. NPM is being a jerk, and having all sorts of errors downloading [email protected]. |
@rwjblue is there an issue with publishing? is it say to merge with that dependency if it isn't downloading? |
I can |
@krisselden travis might just be hitting a bad replica/mirror, install locally works fine. |
Thank you very much, @krisselden! This is some really great work! |
Awesome 👍 |
Move ENV stuff, environment, and context to 'ember-environment'.
This is a first step of many to cleanup dependencies and dependency on the
Ember
global.