[Glimmer2] Port {{textarea}} test to ember-glimmer. #13215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| moduleFor('Helpers test: {{textarea}}', class extends RenderingTest { | ||
|
|
||
| ['@htmlbars Should insert a textarea']() { |
kiwiupover
force-pushed
the
glimmer-textarea-tests
branch
from
7a9e659
to
2d78610
Compare
|
|
||
| moduleFor('Helpers test: {{textarea}}', class extends TextAreaRenderingTest { | ||
|
|
||
| ['@htmlbars Should insert a textarea']() { |
|
@chancancode this is ready for your eyes mate. |
45 tasks
| super(); | ||
|
|
||
| this.registerComponent('-text-area', { ComponentClass: TextArea }); | ||
| this.render('{{textarea disabled=disabled value=val}}', { val: 'Lorem ipsum dolor' }); |
There was a problem hiding this comment.
Since this is so easy to do now, I think we prefer to inline this into the tests now. (See below)
|
Left some minor comments, otherwise looks great to me! Thanks for picking this up! |
kiwiupover
force-pushed
the
glimmer-textarea-tests
branch
from
2d78610
to
592b614
Compare
|
@chancancode This is ready mate! |
|
Thanks @kiwiupover! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.