Show deprecation warning when using didInitAttrs #13207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stearagon
force-pushed
the
deprecate-did-init-attrs
branch
from
51c13ec
to
6ebd9a9
Compare
|
This looks great! Can we also deprecate the following: export default Ember.Component.extend({
doStuff: Ember.on('didInitAttrs', function() {
// stuff!!!!!
})
}); |
stearagon
force-pushed
the
deprecate-did-init-attrs
branch
2 times, most recently
from
7234209
to
bb396fc
Compare
stearagon
force-pushed
the
deprecate-did-init-attrs
branch
from
bb396fc
to
3f7bc15
Compare
|
@rwjblue added deprecation for |
|
Awesome, thank you!! |
brewingcode
added a commit
to brewingcode/ember-google-publisher-tags
that referenced
this pull request
Jul 21, 2016
For one, didInitAttrs() is deprecated, it is now init(): emberjs/ember.js#13207 For another, didReceiveAttrs() runs on re-render, which might be more useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation Guide
Related Issue
This adds deprecation warning when using
didInitAttrs. The preferred way is to now useinit. Refer to related issue for more details.