Begin making it possible to boot apps with ember-glimmer. #13190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for different extension.
Uses an internal symbol to opt-in to glimmer usage instead of an additional function argument.
This is certainly not correct, but unblocks a few tests.
rwjblue
force-pushed
the
rwjblue-running-apps
branch
2 times, most recently
from
730c03f
to
a25bf74
Compare
These tests are being disabled while running with the ember-glimmer flat enabled. We will slowly remove these flags as we complete the Glimmer implementatin, and all of these guarded tests will be reenabled before the feature itself is enabled.
rwjblue
force-pushed
the
rwjblue-running-apps
branch
from
a25bf74
to
72bffc7
Compare
|
Obviously, there is a lot more work to be done (all of these disabled tests need to pass), but once this PR lands it is possible to boot an ember-cli app. |
This was referenced Mar 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.