[BUGFIX release-2-0] Upgrade htmlbars to 0.14.14 #13162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dhaulagiri - The failures seem to be JSHint related (most likely improvements in JSHint parsing engine now catches things that were previously skipped). Can you add a second commit fixing them? |
|
@rwjblue I fixed the jshint errors but there are still quite a few other failures. It's probably not worth spinning tires on this too much since we are just trying to back port this fix. |
|
Hmm, I thought when I looked that there were only the JSHint errors. I'll double check again after Travis is done with this run... |
|
This was not as easy as I hoped so I think our effort is better spent getting our app off 2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the input fix from #12877 to those still on 2.0