[Glimmer2] Add tests for bound {{loc}} behavior #13134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ['@test it updates when bound params change']() { | ||
| let context = { simple: 'Hello Friend', personal: 'Hello' }; | ||
|
|
||
| this.render(`{{loc simple}} - {{loc personal 'Mr. Pitkin'}}`, context); |
There was a problem hiding this comment.
you can just do this.render({{...}}, { simple: ... });
|
r? @mixonic |
Tests INUR cycle for bound params. Fixes emberjs#13132.
code0100fun
force-pushed
the
loc-helper-binding-tests
branch
from
e3c53da
to
1de062d
Compare
|
Looks good 💪 Thanks @code0100fun! |
mixonic
added a commit
that referenced
this pull request
Mar 20, 2016
[Glimmer2] Add tests for bound {{loc}} behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests INUR cycle for bound params. Fixes #13132.