Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More glimmer tests #12891

Merged
merged 2 commits into from
Feb 2, 2016
Merged

More glimmer tests #12891

merged 2 commits into from
Feb 2, 2016

Conversation

chancancode
Copy link
Member

This is the initial work to implement the shared testing infrastructure between ember-htmlbars and ember-glimmer.

Quoting @wycats 😗

It is worth noting that the ember-glimmer tests are using Ember.View and Ember.Component. In order to make these tests pass, we hit a failing test that confirms that the view registry is empty, which means that (1) the view registry was getting populated, and (2) we had to empty it. There's still quite a bit left to do, of course, but this integration is the real deal.

Next steps:

  • Symlink this test file and the shared utils to ember-htmlbars, implement the htmlbars version of the helpers, and make it pass in both packages.
  • Start porting existing tests into the new format and repeat the symlink step.

@rwjblue
Copy link
Member

rwjblue commented Feb 2, 2016

@Serabe - This seems related to your recent PR, mind taking a look?

wycats added a commit that referenced this pull request Feb 2, 2016
@wycats wycats merged commit abdc05f into emberjs:master Feb 2, 2016
@wycats
Copy link
Member

wycats commented Feb 2, 2016

Once we have more tests written this way, we would definitely love to work with @Serabe to get the same style working in more places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants