[BUGFIX canary] Support tagless components in fastboot #12829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to render a component with `tagName: ''` in fastboot kills the fastboot server with a stack trace that looks like:
```
undefined:55214
_emberViewsSystemJquery.default(rootElement).off('.ember', '**').removeC
^
TypeError: undefined is not a function
at exports.default._emberRuntimeSystemObject.default.extend.destroy (<anonymous>:55214:38)
at superWrapper [as destroy] (<anonymous>:33934:22)
at <anonymous>:11887:16
at eachDestroyable (<anonymous>:12166:9)
at Object.Container.destroy (<anonymous>:11885:7)
at Object.Backburner.run (<anonymous>:11256:25)
at Object.run [as default] (<anonymous>:31959:27)
at exports.default._emberMetalMixin.Mixin.create.willDestroy (<anonymous>:44068:36)
at superWrapper (<anonymous>:33934:22)
at _emberRuntimeSystemObject.default.extend.willDestroy (<anonymous>:15925:19)
```
The root cause is that initializing a tagless component causes a lookup of `event_dispatcher:main`. This actually succeeds, and the `EventDispatcher` doesn't try to do anything, but then during container teardown the EventDispatcher's `destroy` method throws the above exception.
To make any future bugs in this class more obvious, I added an assertion in `EventDispatcher` so that it will fail faster if you try to instantiate it in fastboot mode.
|
should we go down a |
|
Do you mean registering a trivial stub object as |
rwjblue
added a commit
that referenced
this pull request
Jan 18, 2016
[BUGFIX canary] Support tagless components in fastboot
|
Note to self, since visit API is now stable this needs to be pulled in to release. |
This was referenced Jan 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to render a component with
tagName: ''in fastboot kills the fastboot server with a stack trace that looks like:The root cause is that initializing a tagless component causes a lookup of
event_dispatcher:main. This actually succeeds, and theEventDispatcherdoesn't try to do anything, but then during container teardown the EventDispatcher'sdestroymethod throws the above exception.To make any future bugs in this class more obvious, I added an assertion in
EventDispatcherso that it will fail faster if you try to instantiate it in fastboot mode.